Opened 3 years ago

Closed 3 years ago

#17965 closed Cleanup/optimization (fixed)

Drop support for Python 2.5

Reported by: jonash Owned by: nobody
Component: Uncategorized Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Patches split into with-statement removal and other various stuff.

Attachments (3)

with_stmts.diff (26.8 KB) - added by jonash 3 years ago.
stuff.diff (7.7 KB) - added by jonash 3 years ago.
stuff_2.diff (18.5 KB) - added by claudep 3 years ago.
Deprecate itercompat.product and more doc fixes

Download all attachments as: .zip

Change History (11)

Changed 3 years ago by jonash

Changed 3 years ago by jonash

comment:1 Changed 3 years ago by Alex

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

Looks good to go, you can probably just kill the import in itercompat, that module isn't a public API. If you want to do another bit of cleanup: UNLEASH THE CLASS DECORATORS.

comment:2 Changed 3 years ago by jezdez

Shouldn't this wait till a release branch is created?

comment:3 Changed 3 years ago by Alex

Yeah, the only reason I haven't committed it already is that I couldn't remember the release branch policy.

comment:4 Changed 3 years ago by Keryn Knight <django@…>

As far as I can tell, the patch provided for stuff.diff doesn't remove the comment about 2.5 compatibility in tests/regressiontests/serializers_regress/tests.py, but with_stmts.diff does remove the import itself.

comment:5 Changed 3 years ago by claudep

In [17828]:

Removed with_statement imports, useless in Python >= 2.6. Refs #17965. Thanks jonash for the patch.

comment:6 Changed 3 years ago by aaugustin

In [17829]:

Use the class decorator syntax available in Python >= 2.6. Refs #17965.

comment:7 Changed 3 years ago by aaugustin

In [17830]:

Removed some Python < 2.6 compatibility code. Refs #17965.

Changed 3 years ago by claudep

Deprecate itercompat.product and more doc fixes

comment:8 Changed 3 years ago by claudep

  • Resolution set to fixed
  • Status changed from new to closed

In [17834]:

Fixed #17965 -- Definitely dropped support for Python 2.5. Thanks jonash for the initial patch and Aymeric Augustin for the review.

Note: See TracTickets for help on using tickets.
Back to Top