[patch] Addition of page_range in paginator.py and generic.list_detail.py

[polarcowz@…]

When using generic views, the desired effect would be:

{% if is_paginated %}
<div class="tablecontrols">

{% for page_number in page_range %}

{% ifequal page_number page %}

{{ page_number }}

{% else %}

<a href="/myapp/clients/{{ page_number }}/" title="Go to page {{ page_number }}">{{ page_number }}</a>

{% endifequal %}

{% endfor %}

</div>
{% endif %}

to dump out a page list like:

[1] [2] [3] [4] [5] [6]

Since some searching turned up no way to do this within the view and I imagine this to be a common problem, I patched "django/core/paginator.py" and "django/views/generic/list_detail.py" to incorporate a new context variable, "page_range". Paginator simply generates a 1-based range up to the total pages. Attached are the patch files.

[polarcowz@…]

Paginator.py Patch

[polarcowz@…]

List_detail.py Patch

[Jure Cuhalev]

Yesterday I was having the same problem when I tried implementing that. In the end I looked how the django admin interface does it and copied bits of that code into my templatetag.

The "problem" with generating pages like this is that if you have hundreds of pages your page list will be too long and since I haven't found templatetag for {% ifbigger %} or {% ifsmaller %} you can't actually limit page_range to a usable range.

I would recommend extending it to actually accept two extra optional parameters that would also give range inside which there should be page range. Otherwise I think this is great idea and would quite simplify this.

[Gary Wilson <gary.wilson@…>]

0.93 has come and gone.

[(none)]

Milestone Version 1.0 deleted

[Simon G. <dev@…>]

I've marked this as Ready-for-checkin as I think it's fairly straight-forward and adds some useful functionality, but it'll need docs.

[Jacob]

Needs documentation; otherwise +1 from me.

[Marc Fargas <telenieko@…>]

Uniffied diff (code, test, docs)

[Marc Fargas <telenieko@…>]

Pagination is currently only explianed in ​generic_views so I added documentation there.
I also added a small test. Patch should be ready as per older comments that's the only missing thing.

[Russell Keith-Magee]

(In [6146]) Fixed #1795 -- Added page_range to paginators in generic list views. Thanks to polarcowz@… and Marc Fargas <telenieko@…> for the patch.