Code

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#17862 closed Bug (wontfix)

Change the frozen send_mail in contrib/suth to EmailMessage

Reported by: karthikabinav Owned by: nobody
Component: contrib.auth Version: 1.3
Severity: Normal Keywords: auth,mail
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The models and forms in contrib/auth still uses send_mail as compared to directly invoking EmailMessage in core/mail

Attachments (1)

patch_send_mail.diff (1.7 KB) - added by karthikabinav 2 years ago.
Changed the send_mail to EmailMessage in contrib/auth

Download all attachments as: .zip

Change History (4)

Changed 2 years ago by karthikabinav

Changed the send_mail to EmailMessage in contrib/auth

comment:1 Changed 2 years ago by claudep

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to wontfix
  • Status changed from new to closed

Thanks for the patch, but I don't see any benefit to replace send_mail by EmailMessage, if you don't use the additional parameters offered by EmailMessage.
API Frozen != deprecated, and I don't see any advantage to this replacement.

comment:2 Changed 2 years ago by karthikabinav

Currently there is no advantage. But it is better to keep it this way so that in future if some additional parameters of EmailMessage needs to be used, it can be used directly.

comment:3 Changed 2 years ago by claudep

Then we can switch at the time we need those parameters.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.