CachedFilesMixin url_converter creates unnecessarily absolute urls
|Reported by:||tgecho||Owned by:||nobody|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
The url converter outputs absolute urls, even if they were originally defined as relative. If I do a collectstatic while DEBUG=True, it uses my local dev STATIC_URL.
So url("../img/shadow.png") becomes url("/static/img/shadow.96b0bd7b6268.png")
Only my production STATIC_URL is 'http://mystatic.s3.amazonaws.com/' so this link is broken when DEBUG=False
That's just a symptom of the problem that the url converter bakes in whatever STATIC_URL is in effect when collectstatic is run. If the final result was a relative path, then it would work wherever the static files ended up living. So ideally url("../img/shadow.png") becomes url(".../img/shadow.96b0bd7b6268.png"). This file would be portable no matter what the STATIC_URL is set to.
Change History (4)
Changed 3 years ago by tgecho
comment:1 Changed 3 years ago by tgecho
- Has patch set
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset