Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#1785 closed (fixed)

debug.py assumes _get_lines_from_file() doesn't return None

Reported by: django@… Owned by: adrian
Component: Core (Other) Version:
Severity: major Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

if an error occurs during view processing, debug.py has a bug such that, on occasion, debug traceback printing fails and you cannot see what your error was. Here's the debug.py traceback. Also see the attached patch for a fix that works in my development environment.

Development server is running at http://127.0.0.1:8000/
Quit the server with CONTROL-C.
[06/May/2006 13:39:57] "GET /rate/1/3?dojo.transport=xmlhttp& HTTP/1.1" 301 0
Traceback (most recent call last):

File "/opt/local/Library/Frameworks/Python.framework/Versions/2.4/lib/python2.4/site-packages/django/core/servers/basehttp.py", line 272, in run

self.result = application(self.environ, self.start_response)

File "/opt/local/Library/Frameworks/Python.framework/Versions/2.4/lib/python2.4/site-packages/django/core/servers/basehttp.py", line 615, in call

return self.application(environ, start_response)

File "/opt/local/Library/Frameworks/Python.framework/Versions/2.4/lib/python2.4/site-packages/django/core/handlers/wsgi.py", line 145, in call

response = self.get_response(request.path, request)

File "/opt/local/Library/Frameworks/Python.framework/Versions/2.4/lib/python2.4/site-packages/django/core/handlers/base.py", line 100, in get_response

return self.get_technical_error_response(request)

File "/opt/local/Library/Frameworks/Python.framework/Versions/2.4/lib/python2.4/site-packages/django/core/handlers/base.py", line 133, in get_technical_error_response

return debug.technical_500_response(request, *sys.exc_info())

File "/opt/local/Library/Frameworks/Python.framework/Versions/2.4/lib/python2.4/site-packages/django/views/debug.py", line 100, in technical_500_response

frames.append({

TypeError: unsupported operand type(s) for +: 'NoneType' and 'int'
[06/May/2006 13:39:57] "GET /rate/1/3/?dojo.transport=xmlhttp HTTP/1.1" 500 1349

Attachments (1)

debug.py.patch (1.3 KB) - added by django@… 9 years ago.
patch for debug.py

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by django@…

patch for debug.py

comment:1 Changed 9 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [2864]) Fixed #1785 -- debug view no longer assumes _get_lines_from_file returns None. Thanks, django@…

comment:2 Changed 9 years ago by Main

  • Type defect deleted
Note: See TracTickets for help on using tickets.
Back to Top