Opened 3 years ago

Closed 3 years ago

#17846 closed Bug (fixed)

Documentation inconsistency for URLField verify_exists param for v1.2

Reported by: anonymous Owned by: nobody
Component: Documentation Version: 1.2
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

"class URLField([verify_exists=False, max_length=200, options])

A CharField for a URL. Has one extra optional argument:

URLField.verify_exists

If True (the default), the URL given will be checked for existence (i.e., the URL actually loads and doesn't give a 404 response).

Note that when you're using the single-threaded development server, validating a URL being served by the same server will hang. This should not be a problem for multithreaded servers.

Changed in Django 1.2: Please, see the release notes"

The description suggests that the default value for this parameter is True, but the declaration suggests that it's False. Additionally, there is no mention of verify_exists in the Django 1.2 release notes.

Change History (4)

comment:1 Changed 3 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

The "Changed in 1.2" reference should actually be "Changed in 1.2.6"; it was modified in response to a security problem that was discovered.

Marking RFC because it's a trivial patch to the docs.

comment:2 Changed 3 years ago by lukegb

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 3 years ago by aaugustin

  • Resolution fixed deleted
  • Status changed from closed to reopened

Maybe I missed something obvious, but I don't see when and how this was fixed?

comment:4 Changed 3 years ago by ramiro

  • Resolution set to fixed
  • Status changed from reopened to closed

In [17677]:

[1.2.X] Fixed #17846 -- Made a note about the micro-version in which a security fix for URLField was introduced in the 1.2.X branch more accurate.

Note: See TracTickets for help on using tickets.
Back to Top