Code

Opened 2 years ago

Closed 2 years ago

#17829 closed Bug (wontfix)

Admin date filter's "Past 7 days" actually returns past 8 days.

Reported by: Glenn Washburn <development@…> Owned by: nobody
Component: contrib.admin Version: 1.4-beta-1
Severity: Normal Keywords:
Cc: Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Essentially the problem is analogous to

 end = 10
 start = end - 7
 qs.filter(f__gte=start, f__lte=end) # this will allow 8 numbers not 7 (namely: [3,4,5,6,7,8,9,10])

I think this is fairly obvious (and easy to fix), but I an explain more if needed.

Attachments (0)

Change History (6)

comment:1 Changed 2 years ago by aaugustin

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to worksforme
  • Status changed from new to closed

list_filter on a DateTimeField is mostly useful if applied to a field that stores a creation or modification date.

It's Monday, 8am. Do you expect to see the updates of last Monday? Probably yes. The filter actually does "Past seven days (complete) + current day (partial)", which was shortened to "Past 7 days" for readability.

In the example above, the current code shows 7,33 days worth of data (assuming you have no data in the future). Your "easy fix" would show 6,33 days instead. I'm not convinced this would be significantly more correct.

We'd need a good reason, good enough to warrant breaking backwards compatibility, to change this.

Last edited 2 years ago by aaugustin (previous) (diff)

comment:2 Changed 2 years ago by Glenn Washburn <development@…>

Yes, I thought about this after submitting the ticket. Though, I think this is still an issue for DateTimeFields. Basically, I think what is expected, is that no future dates are selected (if it can be helped). I don't really care about this being fixed, but I think it is still a bug.

comment:3 Changed 2 years ago by aaugustin

  • Resolution worksforme deleted
  • Status changed from closed to reopened
  • Triage Stage changed from Unreviewed to Design decision needed

comment:4 Changed 2 years ago by aaugustin

To be honest, I don't care much either. Let's keep it as DDN to get more opinions...

comment:5 Changed 2 years ago by hcarvalhoalves

For a end-user, "past 7 days" essentialy means "show me everything since, and including, last <week day>". You don't do the math using hours, you compute with whole days. I believe the current behaviour is the most expected behaviour, or at least the less surprising one.

comment:6 Changed 2 years ago by aaugustin

  • Resolution set to wontfix
  • Status changed from reopened to closed

Yeah, I've just re-implemented this feature in the context of another ticket and I felt like hcarvalhoalves.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.