Opened 5 years ago

Closed 4 years ago

#17818 closed New feature (duplicate)

Generic edit generic views don't create `fail_silently` success messages anymore.

Reported by: Simon Charette Owned by: Simon Charette
Component: Generic views Version: master
Severity: Normal Keywords: views generic edit messages
Cc: marc.tamlyn@…, hirokiky@… Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

It looks like the creation of success messages on valid form submission was oversight when the generic class based views were designed.

Here's a link to the django-developper discussion that motivated the creation of this ticket.

I'm also attaching a patch (with no tests and docs) that provide a simple yet overridable implementation that mimic the deprecated function based behaviour.

Attachments (2)

class-based-generic-edit-views-messages-v1.diff (4.6 KB) - added by Simon Charette 5 years ago.
17818_test_v1.diff (10.2 KB) - added by Hiroki Kiyohara 4 years ago.
Tests for sending messages of edie views.

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by Simon Charette

comment:1 Changed 5 years ago by Aymeric Augustin

Triage Stage: UnreviewedAccepted
Type: UncategorizedNew feature

comment:2 Changed 4 years ago by Marc Tamlyn

Cc: marc.tamlyn@… added
Needs documentation: set
Needs tests: set
Version: 1.3master

I'm +1 on this feature being reintroduced, but -1 on it being on by default, especially as this would constitute a backwards incompatibility to me. We have views around which create messages similar to this, and turning it back on by default would mean duplicate messages, or messages where none were expected.

That said it's probably a useful feature by default, but I think there should be an upgrade path.

Changed 4 years ago by Hiroki Kiyohara

Attachment: 17818_test_v1.diff added

Tests for sending messages of edie views.

comment:3 Changed 4 years ago by Hiroki Kiyohara

Cc: hirokiky@… added
Needs tests: unset

I added a patch for testing this feature.

comment:4 Changed 4 years ago by Simon Charette

Resolution: duplicate
Status: newclosed

Closing as duplicate of #16319.

Note: See TracTickets for help on using tickets.
Back to Top