#17798 closed Cleanup/optimization (fixed)
minor changes in localflavor.ca.ca_provinces
| Reported by: | Sergiy Kuzmenko | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.localflavor | Version: | 1.3 |
| Severity: | Normal | Keywords: | |
| Cc: | lemaire.adrien@… | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
Two changes:
1) Removed RuntimeWarning (seen it enough in 1.3)
2) Added "pq" to PROVINCES_NORMALIZED (PQ is the old code for Quebec which stood for the "Province of Quebec")
Patch attached. I assume no tests are required for this type of change.
Attachments (1)
Change History (11)
comment:1 by , 13 years ago
| Easy pickings: | set |
|---|---|
| Needs tests: | set |
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 13 years ago
| Needs documentation: | set |
|---|
comment:3 by , 13 years ago
comment:4 by , 13 years ago
@shelldweller:
When we make changes to a localflavor reflecting changes in provinces/codes etc, we generally list them in the release notes. For example, in 1.3, we corrected the code for the Yukon territory, and documented it in the release notes. In this case, it's not a backwards incompatible change, but the release notes are still the right place for a note.
comment:5 by , 13 years ago
| Needs documentation: | unset |
|---|
tests pass with python2.5 and python 2.6, but fail with python 2.7
Documentation is ok.
comment:6 by , 13 years ago
| Needs tests: | unset |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
comment:7 by , 13 years ago
| Cc: | added |
|---|
comment:8 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Fixed #17798 -- Tweaked the CA localflavor.
Thanks shelldweller.
Changeset: 46648b641d86b663f825227df5af5473f13a3fb4
comment:9 by , 13 years ago
Fixed #17798 -- Tweaked the CA localflavor.
Thanks shelldweller.
Changeset: 46648b641d86b663f825227df5af5473f13a3fb4
comment:10 by , 13 years ago
Fixed #17798 -- Tweaked the CA localflavor.
Thanks shelldweller.
Changeset: 46648b641d86b663f825227df5af5473f13a3fb4
I'm not sure about documentation. PROVINCES_NORMALIZED is just an implementation detail which isn't documented anywhere presently and adding an extra key to it isn't worth mentioning anyway. RuntimeWarning was to warn users upgrading to 1.3 that there were recent changes in province codes. In 1.4 those changes aren't recent anymore.