Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#17798 closed Cleanup/optimization (fixed)

minor changes in localflavor.ca.ca_provinces

Reported by: shelldweller Owned by: nobody
Component: contrib.localflavor Version: 1.3
Severity: Normal Keywords:
Cc: lemaire.adrien@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Two changes:

1) Removed RuntimeWarning (seen it enough in 1.3)

2) Added "pq" to PROVINCES_NORMALIZED (PQ is the old code for Quebec which stood for the "Province of Quebec")

Patch attached. I assume no tests are required for this type of change.

Attachments (1)

ca_provinces.py.patch (1.7 KB) - added by shelldweller 3 years ago.
Patch with test and doc

Download all attachments as: .zip

Change History (11)

comment:1 Changed 3 years ago by jezdez

  • Easy pickings set
  • Needs documentation unset
  • Needs tests set
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 3 years ago by jezdez

  • Needs documentation set

comment:3 Changed 3 years ago by shelldweller

I'm not sure about documentation. PROVINCES_NORMALIZED is just an implementation detail which isn't documented anywhere presently and adding an extra key to it isn't worth mentioning anyway. RuntimeWarning was to warn users upgrading to 1.3 that there were recent changes in province codes. In 1.4 those changes aren't recent anymore.

comment:4 Changed 3 years ago by russellm

@shelldweller:

When we make changes to a localflavor reflecting changes in provinces/codes etc, we generally list them in the release notes. For example, in 1.3, we corrected the code for the Yukon territory, and documented it in the release notes. In this case, it's not a backwards incompatible change, but the release notes are still the right place for a note.

Changed 3 years ago by shelldweller

Patch with test and doc

comment:5 Changed 3 years ago by Fandekasp

  • Needs documentation unset

EDIT: tests are ok.

Documentation is ok.

Last edited 3 years ago by Fandekasp (previous) (diff)

comment:6 Changed 3 years ago by Fandekasp

  • Needs tests unset
  • Triage Stage changed from Accepted to Ready for checkin

comment:7 Changed 3 years ago by Fandekasp

  • Cc lemaire.adrien@… added

comment:8 Changed 3 years ago by Aymeric Augustin

  • Resolution set to fixed
  • Status changed from new to closed

Fixed #17798 -- Tweaked the CA localflavor.

Thanks shelldweller.

Changeset: 46648b641d86b663f825227df5af5473f13a3fb4

comment:9 Changed 3 years ago by Aymeric Augustin

Fixed #17798 -- Tweaked the CA localflavor.

Thanks shelldweller.

Changeset: 46648b641d86b663f825227df5af5473f13a3fb4

comment:10 Changed 3 years ago by Aymeric Augustin

Fixed #17798 -- Tweaked the CA localflavor.

Thanks shelldweller.

Changeset: 46648b641d86b663f825227df5af5473f13a3fb4

Note: See TracTickets for help on using tickets.
Back to Top