makemessages command walks through directories that match ignore_patterns
|Reported by:||andreiko||Owned by:||nobody|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
./manage.py makemessages always walks through all directories in a tree, even if some directory's path matches an ignore pattern.
So we perform meaningless time-consuming scan through .svn, .git and other possible deep directories that we would like to fully ignore:
$ ./manage.py makemessages -l ru -d django -v 2 examining files with the extensions: .html processing language ru ignoring file .DS_Store in . ignoring file .gitignore in . ... ignoring file e974710282570831dbefad0e177403d07205ba in ./.git/objects/07 ignoring file da4359b0e24cb164eace2ac312af8fafff2127 in ./.git/objects/08 ignoring file f195d5a9e0cf3542ef36028fa4820d8cdf560a in ./.git/objects/08 ignoring file 26c086ebf3d6fee600fccddaf6bbc6a7f347a1 in ./.git/objects/0a ...
Suggested patch changes behavior of "walk" function defined in makemessages.py to skip directories which path matches some ignore pattern.
Change History (4)
Changed 5 years ago by andreiko
Changed 5 years ago by claudep
comment:1 Changed 5 years ago by claudep
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
- Triage Stage changed from Unreviewed to Accepted
- Type changed from Bug to Cleanup/optimization