DateTimeFields don't handle timezones when given datetime.date instances

[Jannis Leidel]

When DateTimeFields get passed datetime.date instances it converts the values in datetime.datetime values, without using the new timezone feature.

source:django/trunk/django/db/models/fields/__init__.py?rev=17148#L750

[Aymeric Augustin]

When time zone support is enabled, the date value should be converted to an aware datetime in the default time zone, with a warning.

[Jannis Leidel]

Agreed in general, but I don't think a warning is appropriate here. Passing a date instance is a perfectly fine use case and can't be made timezone aware like datetime instances by passing a tzinfo parameter.

[Aymeric Augustin]

Indeed, a date can't be timezone aware, which means it can't be interpreted unambiguously as a timezone aware datetime.

That's why I proposed to raise a warning when USE_TZ = True, exactly like I do when a DateTimeField receives a naive datetime.

[Jannis Leidel]

In [17392]:

Fixed #17580 -- Made sure datetime.date instances are correctly handled when being passed to a DateTimeField fields and the timezone support is enabled by making it aware using the default timezone.

[Aymeric Augustin]

In [17403]:

(The changeset message doesn't reference this ticket)