Opened 13 years ago
Closed 12 years ago
#17574 closed Cleanup/optimization (fixed)
Cleanup in the introspection code
Reported by: | Claude Paroz | Owned by: | nobody |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | dev |
Severity: | Normal | Keywords: | introspection |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
While working on #7783, I did some improvements on the introspection code:
- moved the 'standard' get_primary_key_column at base backend (only SQLite overrides it)
- added the missing get_key_columns implementation for PostgreSQL
- in tests, the IgnoreNotimplementedError class should be replaced by @skip decorators if needed
- test_get_key_columns should be skipped on MySQL with MyISAM engine
Tested with SQLite, MySQL (InnoDB and MyISAM), PostgreSQL. I don't have access to Oracle to test.
Attachments (2)
Change History (6)
by , 13 years ago
Attachment: | 17574-1.diff added |
---|
comment:1 by , 13 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:4 by , 12 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Introspection code improvements