Opened 5 years ago

Closed 5 years ago

#17521 closed Cleanup/optimization (fixed)

Only use minified JavaScript when DEBUG is off

Reported by: Travis Swicegood Owned by: Wiktor
Component: contrib.admin Version: 1.4-alpha-1
Severity: Normal Keywords: javascript, admin
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This makes it easier to inspect the code that is being used when trying to track down a problem in the JavaScript.

Attachments (2)

fix-js-for-debug-v1.patch (2.4 KB) - added by Travis Swicegood 5 years ago.
ticket17521.diff (5.1 KB) - added by Wiktor 5 years ago.
Patch + tests

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by Travis Swicegood

Attachment: fix-js-for-debug-v1.patch added

comment:1 Changed 5 years ago by Travis Swicegood

Needs documentation: unset
Needs tests: set
Patch needs improvement: unset

See also https://github.com/django/django/pull/103

Open to ideas on testing this...?

comment:2 Changed 5 years ago by Aymeric Augustin

Triage Stage: UnreviewedAccepted

comment:3 Changed 5 years ago by Wiktor

Owner: changed from nobody to Wiktor

Changed 5 years ago by Wiktor

Attachment: ticket17521.diff added

Patch + tests

comment:4 Changed 5 years ago by Radosław Sieradzki

Needs tests: unset
Triage Stage: AcceptedReady for checkin

comment:5 Changed 5 years ago by Wiktor

Status: newassigned

comment:6 Changed 5 years ago by Julien Phalip

Resolution: fixed
Status: assignedclosed

In [17454]:

Fixed #17521 -- Made the minified JS files be used in the admin only when DEBUG is False. Thanks to Travis Swicegood for the suggestion and patch, and to viciu for the tests.

Note: See TracTickets for help on using tickets.
Back to Top