Opened 13 years ago

Closed 13 years ago

#17521 closed Cleanup/optimization (fixed)

Only use minified JavaScript when DEBUG is off

Reported by: Travis Swicegood Owned by: Wiktor
Component: contrib.admin Version: 1.4-alpha-1
Severity: Normal Keywords: javascript, admin
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This makes it easier to inspect the code that is being used when trying to track down a problem in the JavaScript.

Attachments (2)

fix-js-for-debug-v1.patch​ (2.4 KB ) - added by Travis Swicegood 13 years ago.
ticket17521.diff​ (5.1 KB ) - added by Wiktor 13 years ago.
Patch + tests

Download all attachments as: .zip

Change History (8)

by Travis Swicegood, 13 years ago

Attachment: fix-js-for-debug-v1.patch​ added

comment:1 by Travis Swicegood, 13 years ago

Needs tests: set

See also ​https://github.com/django/django/pull/103

Open to ideas on testing this...?

comment:2 by Aymeric Augustin, 13 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Wiktor, 13 years ago

Owner: changed from nobody to Wiktor

by Wiktor, 13 years ago

Attachment: ticket17521.diff​ added

Patch + tests

comment:4 by Radosław Sieradzki, 13 years ago

Needs tests: unset
Triage Stage: Accepted → Ready for checkin

comment:5 by Wiktor, 13 years ago

Status: new → assigned

comment:6 by Julien Phalip, 13 years ago

Resolution: → fixed
Status: assigned → closed

In [17454]:

Fixed #17521 -- Made the minified JS files be used in the admin only when DEBUG is False. Thanks to Travis Swicegood for the suggestion and patch, and to viciu for the tests.

Note: See TracTickets for help on using tickets.
Back to Top