Code

Opened 3 years ago

Closed 2 years ago

#17521 closed Cleanup/optimization (fixed)

Only use minified JavaScript when DEBUG is off

Reported by: tswicegood Owned by: viciu
Component: contrib.admin Version: 1.4-alpha-1
Severity: Normal Keywords: javascript, admin
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This makes it easier to inspect the code that is being used when trying to track down a problem in the JavaScript.

Attachments (2)

fix-js-for-debug-v1.patch (2.4 KB) - added by tswicegood 3 years ago.
ticket17521.diff (5.1 KB) - added by viciu 2 years ago.
Patch + tests

Download all attachments as: .zip

Change History (8)

Changed 3 years ago by tswicegood

comment:1 Changed 3 years ago by tswicegood

  • Needs documentation unset
  • Needs tests set
  • Patch needs improvement unset

See also https://github.com/django/django/pull/103

Open to ideas on testing this...?

comment:2 Changed 3 years ago by aaugustin

  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 2 years ago by viciu

  • Owner changed from nobody to viciu

Changed 2 years ago by viciu

Patch + tests

comment:4 Changed 2 years ago by rsiera

  • Needs tests unset
  • Triage Stage changed from Accepted to Ready for checkin

comment:5 Changed 2 years ago by viciu

  • Status changed from new to assigned

comment:6 Changed 2 years ago by julien

  • Resolution set to fixed
  • Status changed from assigned to closed

In [17454]:

Fixed #17521 -- Made the minified JS files be used in the admin only when DEBUG is False. Thanks to Travis Swicegood for the suggestion and patch, and to viciu for the tests.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.