Opened 13 years ago
Closed 13 years ago
#17504 closed Bug (fixed)
User.objects.create_user() wrong email domain part identification
Reported by: | fero | Owned by: | marw85 |
---|---|---|---|
Component: | contrib.auth | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description
According to http://tools.ietf.org/html/rfc3696#section-3 the "@" symbol can be part of the local part of an email address, so line 129 of contrib.auth.models is bugged.
The unbelivable complex ;) patch is:
- email_name, domain_part = email.strip().split('@', 1) + email_name, domain_part = email.strip().rsplit('@', 1)
Attachments (2)
Change History (8)
comment:1 by , 13 years ago
Has patch: | set |
---|
comment:2 by , 13 years ago
Easy pickings: | set |
---|---|
Needs tests: | set |
Triage Stage: | Unreviewed → Accepted |
by , 13 years ago
Attachment: | patch.diff added |
---|
comment:3 by , 13 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
by , 13 years ago
Attachment: | django-17504.2.diff added |
---|
comment:5 by , 13 years ago
Needs tests: | unset |
---|---|
Triage Stage: | Accepted → Ready for checkin |
Note:
See TracTickets
for help on using tickets.
Replaced with the last occurence of @ symbol