Opened 13 years ago
Closed 13 years ago
#17499 closed Bug (fixed)
assertFieldOutput fails if field has customized required message
Reported by: | dpifke | Owned by: | nobody |
---|---|---|---|
Component: | Testing framework | Version: | 1.3 |
Severity: | Release blocker | Keywords: | |
Cc: | claude@… | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description
The string u'This field is required.'
is hard-coded into the field checks in SimpleTestCase.assertFieldOutput()
. This causes tests using this method to always fail for fields which have customized default_error_messages
.
Proposed fix would be to use the string from the field's error_messages
dictionary instead; one-line patch to do so forthcoming.
Attachments (2)
Change History (5)
by , 13 years ago
Attachment: | assertfieldoutput.patch added |
---|
comment:1 by , 13 years ago
Needs tests: | set |
---|---|
Severity: | Normal → Release blocker |
Triage Stage: | Unreviewed → Accepted |
Thank you for the report. Could you please provide some tests?
Marking as release blocker since it's a new feature in 1.4.
comment:2 by , 13 years ago
Cc: | added |
---|---|
Needs tests: | unset |
Note:
See TracTickets
for help on using tickets.
Proposed patch against trunk