add KEY to HIDDEN_SETTINGS regexp

[daenney]

The HIDDEN_SETTINGS regexp is very useful but currently doesn't do much to obfuscate things such as API_KEY settings which are becoming more and more common to hook into additional services.

This would also be solved if/when #16435 gets resolved as it would allow people to add KEY to that regexp themselves.

However, for now and because the usage of such API key's is mainstream, I think it would be a good idea to add KEY to the default HIDDEN_SETTINGS regexp.

[daenney]

TOKEN and PASS would be two other fairly common used names for such variables.

[daenney]

Added patch.

[Gabriel Hurley]

I'm a little loathe to see more work happen on HIDDEN_SETTINGS when it's such an ugly solution to begin with. Especially now that we have ​custom error reporting. It'd be so much better to see this be part of a common solution to #16435 as noted.

However, those are common sensitive values, so I'll accept the ticket for now.

[Bas Peschier]

Cleaned up the diff so it patches from the root; please remember that the next time you write a patch, it just makes it easier to review the ticket.

I agree with the "should be fixed with a better solution all together", but it does not make the HIDDEN_SETTINGS worse by adding a few good values.

[Aymeric Augustin]

Note that PASS and PASSWORD are redundant in the regexp.

I'm not sure if this needs tests (probably not) or docs (two lines in the "backward-incompatible changes" section of the release notes?).

[Bas Peschier]

Good catch, the ​docs actually *do* specify which settings get hidden, so updated docs are needed. A mention in the release notes is a good idea as well.

[daenney]

Attached a newer version of the patch that also updates the docs to reflect the changes.

[daenney]

There's another little issue with the docs, the docs say anything that contains PROFANITIES will match but the HIDDEN_SETTINGS regexp specifies PROFANITIES_LIST as it's pattern so as far as I know PROFANITIES_CAKE won't match in that case.

[Tomasz Rybak]

Fixed doc to be the same as regexp

[Tomasz Rybak]

Now documentation matches regexp HIDDEN_SETTINGS from patch (hidden_settings3.patch).

[chomik]

patch with improved documentation and release notes for 1.4-beta-1

[lpiatek]

Patch also adds release notes for 1.4-beta-1, which are basicly release notes from 1.4-aplha-1 with aplpha to beta changes where necessary.

I think it is ready for check in.

[Jannis Leidel]

In [17481]:

(The changeset message doesn't reference this ticket)