Opened 13 years ago
Closed 13 years ago
#17443 closed Uncategorized (needsinfo)
[patch] Cookie overrides language session value before language variations are looked for
Reported by: | sdistefano | Owned by: | nobody |
---|---|---|---|
Component: | Internationalization | Version: | 1.3 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
Not sure if the fix is ideal, but it works. Without it, the cookie will take precedence over session['django_language']
unless there is an exact match (not just base_lang).
Attachments (1)
Change History (3)
by , 13 years ago
Attachment: | cookie_overrides_session_lang_variations.patch added |
---|
comment:1 by , 13 years ago
Description: | modified (diff) |
---|
comment:2 by , 13 years ago
Resolution: | → needsinfo |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Given that
session['django_language']
is under your control, I don't see why you'd set it to a code that doesn't appear in yoursettings.LANGUAGES
.Could you clarify the use case for this change?