Opened 5 years ago

Closed 5 years ago

#17443 closed Uncategorized (needsinfo)

[patch] Cookie overrides language session value before language variations are looked for

Reported by: sdistefano Owned by: nobody
Component: Internationalization Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by aaugustin)

Not sure if the fix is ideal, but it works. Without it, the cookie will take precedence over session['django_language'] unless there is an exact match (not just base_lang).

Attachments (1)

cookie_overrides_session_lang_variations.patch (813 bytes) - added by sdistefano 5 years ago.

Download all attachments as: .zip

Change History (3)

Changed 5 years ago by sdistefano

comment:1 Changed 5 years ago by aaugustin

  • Description modified (diff)
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 5 years ago by aaugustin

  • Resolution set to needsinfo
  • Status changed from new to closed

Given that session['django_language'] is under your control, I don't see why you'd set it to a code that doesn't appear in your settings.LANGUAGES.

Could you clarify the use case for this change?

Note: See TracTickets for help on using tickets.
Back to Top