Opened 4 years ago

Closed 4 years ago

#17437 closed Cleanup/optimization (wontfix)

Static file finder are styled as finders.AppDirectoriesFinder while template loaders are styled as loaders.app_directories.Loader

Reported by: anonymous Owned by: nobody
Component: Template system Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


Shouldn't the template loaders be refactored to use the same style as the static file finders? (i.e. loaders.AppDirectoriesLoader)

Change History (6)

comment:1 Changed 4 years ago by aaugustin

  • Easy pickings unset
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

I'm not convinced the gain in consistency is worth the backwards incompatibility.

comment:2 Changed 4 years ago by anonymous

Can't the transition be done in a backwards-compatible way, at least until Django 1.5 or something?

comment:3 Changed 4 years ago by jezdez

  • Component changed from Template system to contrib.staticfiles

comment:4 Changed 4 years ago by jezdez

  • Component changed from contrib.staticfiles to Template system

Oh wait, the summary confused me for a second..

comment:5 Changed 4 years ago by gabrielhurley

This definitely feels like shuffling deck chairs... While I love consistency, the value of it weighed against an entire deprecation process is uninspiring. I'm generally -1 on renaming anything just for the sake of renaming.

comment:6 Changed 4 years ago by aaugustin

  • Resolution set to wontfix
  • Status changed from new to closed

I agree with Gabriel.

Note: See TracTickets for help on using tickets.
Back to Top