Opened 5 years ago

Closed 5 years ago

#17422 closed Bug (fixed)

BaseDetailView get method doesn't take the *args argument

Reported by: anonymous Owned by: nobody
Component: Generic views Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

BaseDetailView is the only CBV whose get method doesn't have the signature def get(self, request, *args, **kwargs): for the sake of consistency this should be fixed.

Inconsistency like this one or #17381 make it rather difficult to grasp what's going on when using the various generic CBV as a basis for custom CBV.

Attachments (1)

detail.py.patch (520 bytes) - added by anonymous 5 years ago.

Download all attachments as: .zip

Change History (2)

Changed 5 years ago by anonymous

Attachment: detail.py.patch added

comment:1 Changed 5 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

In [17216]:

Fixed #17422 -- Changed BaseDetailView to use *args, to be consistent with other views

Note: See TracTickets for help on using tickets.
Back to Top