Code

Opened 2 years ago

Closed 2 years ago

#17422 closed Bug (fixed)

BaseDetailView get method doesn't take the *args argument

Reported by: anonymous Owned by: nobody
Component: Generic views Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: no UI/UX: no

Description

BaseDetailView is the only CBV whose get method doesn't have the signature def get(self, request, *args, **kwargs): for the sake of consistency this should be fixed.

Inconsistency like this one or #17381 make it rather difficult to grasp what's going on when using the various generic CBV as a basis for custom CBV.

Attachments (1)

detail.py.patch (520 bytes) - added by anonymous 2 years ago.

Download all attachments as: .zip

Change History (2)

Changed 2 years ago by anonymous

comment:1 Changed 2 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

In [17216]:

Fixed #17422 -- Changed BaseDetailView to use *args, to be consistent with other views

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.