Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#17390 closed Cleanup/optimization (fixed)

Describe how to do auth for Class Based Views in the main Auth docs

Reported by: ncoghlan@… Owned by: Zbigniew Siciarz
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: asendecka@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

https://docs.djangoproject.com/en/dev/topics/auth/#limiting-access-to-generic-views only talks about function views.

It should also describe how to decorate Class Based Views, or at least link to the following subsection of the CBV docs:
https://docs.djangoproject.com/en/dev/topics/class-based-views/#decorating-class-based-views

Attachments (1)

patch_17390.diff (1.9 KB) - added by Zbigniew Siciarz 5 years ago.
Mentioned decorating CBVs in the contrib.auth docs.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 5 years ago by Bas Peschier

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

Good catch, should describe the non-deprecated method of generic views.

comment:2 Changed 5 years ago by Zbigniew Siciarz

Owner: changed from nobody to Zbigniew Siciarz

Changed 5 years ago by Zbigniew Siciarz

Attachment: patch_17390.diff added

Mentioned decorating CBVs in the contrib.auth docs.

comment:3 Changed 5 years ago by Zbigniew Siciarz

Has patch: set

comment:4 Changed 5 years ago by Aleksandra Sendecka

Cc: asendecka@… added
Triage Stage: AcceptedReady for checkin

I think it's ok.

comment:5 Changed 5 years ago by Tim Graham

Resolution: fixed
Status: newclosed

In [17564]:

Fixed #17390 - Added a note to topics/auth.txt regarding how to decorate class-based generic views; thanks zsiciarz for the patch.

comment:6 Changed 5 years ago by Tim Graham

In [17565]:

[1.3.X] Fixed #17390 - Added a note to topics/auth.txt regarding how to decorate class-based generic views; thanks zsiciarz for the patch.

Backport of r17564 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top