Code

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#17390 closed Cleanup/optimization (fixed)

Describe how to do auth for Class Based Views in the main Auth docs

Reported by: ncoghlan@… Owned by: zsiciarz
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: asendecka@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

https://docs.djangoproject.com/en/dev/topics/auth/#limiting-access-to-generic-views only talks about function views.

It should also describe how to decorate Class Based Views, or at least link to the following subsection of the CBV docs:
https://docs.djangoproject.com/en/dev/topics/class-based-views/#decorating-class-based-views

Attachments (1)

patch_17390.diff (1.9 KB) - added by zsiciarz 2 years ago.
Mentioned decorating CBVs in the contrib.auth docs.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 3 years ago by bpeschier

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Good catch, should describe the non-deprecated method of generic views.

comment:2 Changed 2 years ago by zsiciarz

  • Owner changed from nobody to zsiciarz

Changed 2 years ago by zsiciarz

Mentioned decorating CBVs in the contrib.auth docs.

comment:3 Changed 2 years ago by zsiciarz

  • Has patch set

comment:4 Changed 2 years ago by ethlinn

  • Cc asendecka@… added
  • Triage Stage changed from Accepted to Ready for checkin

I think it's ok.

comment:5 Changed 2 years ago by timo

  • Resolution set to fixed
  • Status changed from new to closed

In [17564]:

Fixed #17390 - Added a note to topics/auth.txt regarding how to decorate class-based generic views; thanks zsiciarz for the patch.

comment:6 Changed 2 years ago by timo

In [17565]:

[1.3.X] Fixed #17390 - Added a note to topics/auth.txt regarding how to decorate class-based generic views; thanks zsiciarz for the patch.

Backport of r17564 from trunk.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.