Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#17390 closed Cleanup/optimization (fixed)

Describe how to do auth for Class Based Views in the main Auth docs

Reported by: ncoghlan@… Owned by: Zbigniew Siciarz
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: asendecka@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

​https://docs.djangoproject.com/en/dev/topics/auth/#limiting-access-to-generic-views only talks about function views.

It should also describe how to decorate Class Based Views, or at least link to the following subsection of the CBV docs:
​https://docs.djangoproject.com/en/dev/topics/class-based-views/#decorating-class-based-views

Attachments (1)

patch_17390.diff​ (1.9 KB ) - added by Zbigniew Siciarz 13 years ago.
Mentioned decorating CBVs in the contrib.auth docs.

Download all attachments as: .zip

Change History (7)

comment:1 by Bas Peschier, 13 years ago

Triage Stage: Unreviewed → Accepted

Good catch, should describe the non-deprecated method of generic views.

comment:2 by Zbigniew Siciarz, 13 years ago

Owner: changed from nobody to Zbigniew Siciarz

by Zbigniew Siciarz, 13 years ago

Attachment: patch_17390.diff​ added

Mentioned decorating CBVs in the contrib.auth docs.

comment:3 by Zbigniew Siciarz, 13 years ago

Has patch: set

comment:4 by Aleksandra Sendecka, 13 years ago

Cc: asendecka@… added
Triage Stage: Accepted → Ready for checkin

I think it's ok.

comment:5 by Tim Graham, 13 years ago

Resolution: → fixed
Status: new → closed

In [17564]:

Fixed #17390 - Added a note to topics/auth.txt regarding how to decorate class-based generic views; thanks zsiciarz for the patch.

comment:6 by Tim Graham, 13 years ago

In [17565]:

(The changeset message doesn't reference this ticket)

Note: See TracTickets for help on using tickets.
Back to Top