Opened 13 years ago
Last modified 2 years ago
#17337 new Bug
[nonrel] Support for non-integer AutoFields
Reported by: | Jonas H. | Owned by: | |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | dev |
Severity: | Normal | Keywords: | nonrel |
Cc: | Brian Helba, raydeal | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | no |
Description
(This patch is part of the changes made to the inofficial fork "Django-nonrel" which adds basic support for non-relational databases.)
This patch adds basic support for non-integer primary keys. It works by not restricting primary keys to int
and factoring out pk validation/type conversion into the backend.
Attachments (1)
Change History (13)
by , 13 years ago
Attachment: | nonint-autoid.patch added |
---|
comment:1 by , 13 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 13 years ago
IIRC, Alex's GSoC code punted on this issue (or, at least, had code that wasn't suitable for trunk), because we couldn't come up with a way to introduce it without introducing backwards incompatibilities. I seem to recall there were a bunch of places in the code that assumed that AutoFields were integers; however, it's been a while, so I might be mis-remembering.
comment:3 by , 13 years ago
A few contrib apps assume PKs to be integers and also it gets tricky when it comes to testing with fixtures. Should we address all these issues at once or fix them bit by bit in multiple tickets?
comment:4 by , 13 years ago
Type: | Uncategorized → Bug |
---|
Two tickets (#17214, #17122) were recently reported about problems in the admin with models using non-integer primary keys. A quick search for "primary_key" turns up several problems with non-integer primary keys, but I think these should be handled separately.
I'm updating the title to reflect that this ticket is about non-integer automatic primary keys.
comment:5 by , 13 years ago
Summary: | [nonrel] Support for non-integer primary keys → [nonrel] Support for non-integer automatic primary keys |
---|
comment:6 by , 11 years ago
Patch needs improvement: | set |
---|
comment:7 by , 10 years ago
Summary: | [nonrel] Support for non-integer automatic primary keys → [nonrel] Support for non-integer AutoFields |
---|
comment:8 by , 5 years ago
comment:10 by , 3 years ago
Cc: | added |
---|
comment:11 by , 3 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:12 by , 2 years ago
Cc: | added |
---|---|
Owner: | removed |
Status: | assigned → new |
Accepting the ticket, as support for non-integer auto-fields is certainly desirable. I believe there's a different implementation of it in Alex Gaynor's 2010 GSoC code - I don't know which implementation is preferable.