Opened 11 years ago
Closed 11 years ago
#17334 closed Cleanup/optimization (fixed)
Document the commit message style for backports
Reported by: | Aymeric Augustin | Owned by: | Christopher Medrela |
---|---|---|---|
Component: | Documentation | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description
As discussed in #django-dev, it seems that the appropriate style is:
[1.3.X] Fixed #**** -- Frobnicated spam around. Backport of r*****.
Attachments (2)
Change History (6)
Changed 11 years ago by
Attachment: | 17334.diff added |
---|
comment:1 Changed 11 years ago by
Has patch: | set |
---|---|
Owner: | changed from nobody to Christopher Medrela |
Status: | new → assigned |
comment:2 Changed 11 years ago by
Patch needs improvement: | set |
---|
Changed 11 years ago by
Attachment: | 17334_v2.diff added |
---|
comment:3 Changed 11 years ago by
Patch needs improvement: | unset |
---|
Sorry for this stupid mistake. The pattern of commit messages is in past tense, so I thought the problem of tenses disappeared. I didn't notice that the problem actually did not disappeare because the pattern doesn't mention tense of description.
Note: See
TracTickets for help on using
tickets.
Why do the proposed patch remove the following text?
I'm not aware of any discussion and agreement about that requirement being changed or relaxed.