Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#17316 closed Cleanup/optimization (fixed)

settings.APPEND_SLASH (CommonMiddleware) does not work well behind multiple proxies

Reported by: Damien Nozay Owned by: nobody
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Aymeric Augustin)

I'm using the MultipleProxyMiddleware middleware.
settings.APPEND_SLASH defaults to True.

MultipleProxyMiddleware needs to be enabled *before* CommonMiddleware for APPEND_SLASH to work.

Maybe all this needs is a few more lines where MultipleProxyMiddleware is documented (or directions to put MultipleProxyMiddleware first would work too I guess).

Attachments (1)

17316.patch (707 bytes) - added by Aymeric Augustin 5 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 5 years ago by Aymeric Augustin

Description: modified (diff)
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

Fixed formatting.

Changed 5 years ago by Aymeric Augustin

Attachment: 17316.patch added

comment:2 Changed 5 years ago by Aymeric Augustin

Component: UncategorizedDocumentation
Easy pickings: set
Has patch: set
Triage Stage: UnreviewedAccepted
Type: UncategorizedCleanup/optimization

comment:3 Changed 5 years ago by Jannis Leidel

Triage Stage: AcceptedReady for checkin

comment:4 Changed 5 years ago by Aymeric Augustin

Resolution: fixed
Status: newclosed

In [17556]:

Fixed #17316 -- Mentionned that the MultipleProxyMiddleware provided as an example must run rather early.

comment:5 Changed 5 years ago by Aymeric Augustin

In [17557]:

(The changeset message doesn't reference this ticket)

Note: See TracTickets for help on using tickets.
Back to Top