[patch] ORM shouldn't add table prefix for a custom SELECT column

[Cheng Zhang <czhang.cmu+web@…>]

For code like this:

from mysite.polls.models import Poll, Choice
from django.db import connection

select = {
 'choices': 'SELECT COUNT(*) FROM polls_choice WHERE poll_id=polls_poll.id',
}
p = Poll.objects.extra(select=select).order_by('choices')
try:
	print "p=", p
except:
	pass
print "db.queries=%s" % connection.queries

The ORM generates SQL statement as:

SELECT "polls_poll"."id","polls_poll"."question","polls_poll"."pub_date",
(SELECT COUNT(*) FROM polls_choice WHERE poll_id=polls_poll.id) AS "choices"
FROM "polls_poll" ORDER BY "polls_poll"."choices" ASC

That's incorrect. The correct statement should be:

SELECT "polls_poll"."id","polls_poll"."question","polls_poll"."pub_date",
(SELECT COUNT(*) FROM polls_choice WHERE poll_id=polls_poll.id) AS "choices"
FROM "polls_poll" ORDER BY "choices" ASC

A patch will follow.

[Adrian Holovaty]

Hmm, this is an undoing of [2803], which was done to fix ordering with a custom select. Can we solve both problems?

[Russell Keith-Magee]

AFAICT, this is a duplicate of #1685, which has the same patch as [2803], not a reversal.