select_for_update tests threads should close connections manually
|Reported by:||akaariai||Owned by:||aaugustin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
This is a small patch which closes two connections taken in threads.
It is good to close the conncetions manually, as they are thread locals in DatabaseWrapper, and thus new connections are created for new threads.
The connections will be closed by GC eventually, but IMHO it is good practice to close the connections manually, as they will not be used again anyways. They will be idle in transaction until they happen to be GCed.
Change History (7)
Changed 3 years ago by akaariai
comment:1 Changed 3 years ago by akaariai
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset