Opened 12 years ago

Closed 12 years ago

#17197 closed Bug (fixed)

Fix translation leakage in the test_suite

Reported by: Florian Apolloner Owned by: nobody
Component: Testing framework Version: dev
Severity: Release blocker Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As currently seen by ​http://ci.django-cms.org/job/Django/ we do have a translation leakage in the testsuite. Although it doesn't seem to manifest on all systems a paired testrun should give you errors as soon as you pair it with views, or just run the testsuite for "views admin_filters". Attached is a patch which fixes the translation leakage.

Attachments (3)

fix_testsuite_translation_leakage.diff​ (2.1 KB ) - added by Florian Apolloner 12 years ago.
fix_testsuite_translation_leakage2.diff​ (1.2 KB ) - added by Florian Apolloner 12 years ago.
fix_testsuite_translation_leakage3.diff​ (1.1 KB ) - added by Florian Apolloner 12 years ago.

Download all attachments as: .zip

Change History (6)

by Florian Apolloner, 12 years ago

Attachment: fix_testsuite_translation_leakage.diff​ added

by Florian Apolloner, 12 years ago

Attachment: fix_testsuite_translation_leakage2.diff​ added

comment:1 by Florian Apolloner, 12 years ago

New patch which doesn't make the fixed test a noop ;)

by Florian Apolloner, 12 years ago

Attachment: fix_testsuite_translation_leakage3.diff​ added

comment:2 by Florian Apolloner, 12 years ago

Updated patch as suggested by julien.

comment:3 by Julien Phalip, 12 years ago

Resolution: → fixed
Status: new → closed

In [17080]:

Fixed #17197 -- Prevented a locale leakage from an i18n test causing collateral failures in the rest of the test suite. Thanks to Florian Apolloner for the report and patch.

Note: See TracTickets for help on using tickets.
Back to Top