#17138 closed Cleanup/optimization (fixed)
Admin sets the "summary" attribute on table, which is obsolete
| Reported by: | Aymeric Augustin | Owned by: | teraom |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
The admin templates were recently converted to HTML5. Since then, the W3C validator raises the following error on the admin index:
The summary attribute is obsolete. Consider describing the structure of the table in a caption element or in a figure element containing the table; or, simplify the structure of the table so that no description is needed.
Attachments (1)
Change History (12)
comment:1 by , 13 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 13 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
by , 13 years ago
| Attachment: | html5-remove-summary-17138.diff added |
|---|
comment:3 by , 13 years ago
| Has patch: | set |
|---|
comment:4 by , 13 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
comment:5 by , 13 years ago
comment:7 by , 13 years ago
| Triage Stage: | Ready for checkin → Accepted |
|---|
Yes, the problem reported might be real but the proposed solution isn't semantically right for our use case. Moving back to accepted.
comment:8 by , 13 years ago
Created a pull request for this: https://github.com/django/django/pull/104
It moves the contents of the summary attribute into the title attribute of the a tag. This may be more useful than before because the summary tag was usually completely thrown away by most browsers. In this case, in most browsers, hovering over the text in the table caption will show the desired "summary"
comment:9 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:11 by , 13 years ago
Sorry, I've referenced the wrong ticket in the commit message above. It should have been #18379.
I'm not sure this is ready. Summary attribute was not displayed by default in browsers, while caption tag is. I'm not sure we suddenly want to display the summary content.