#17100 closed Bug (fixed)
Possible bad regex for email validator
Reported by: | Owned by: | nobody | |
---|---|---|---|
Component: | Core (Other) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Around line 150 of /django/core/validators.py is a line in which I think there's a missing backslash:
r'|^"([\001-\010\013\014\016-\037!#-\[\]-\177]|\\[\001-011\013\014\016-\177])*"' # quoted-string missing backslash? ----^
If you look at the debug output of that part of the regex, I think the backslash is what is meant.
>>> re.compile(r'[\001-\011]', re.DEBUG) in range (1, 9) <_sre.SRE_Pattern object at 0x137e9b0> >>> re.compile(r'[\001-011]', re.DEBUG) in range (1, 48) literal 49 literal 49 <_sre.SRE_Pattern object at 0x137ea48>
Given this, the following email should fail: "\12"@example.com
A test case:
assert(email_re.match('"\\\12"@example.com') == None)
Attachments (1)
Change History (7)
comment:1 by , 13 years ago
Triage Stage: | Unreviewed → Accepted |
---|
by , 13 years ago
Attachment: | 17100.diff added |
---|
comment:2 by , 13 years ago
Has patch: | set |
---|
comment:4 by , 13 years ago
Type: | Uncategorized → Bug |
---|---|
Version: | 1.3 → SVN |
Note:
See TracTickets
for help on using tickets.
Fix missing backslash and tests