Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#17100 closed Bug (fixed)

Possible bad regex for email validator

Reported by: reames@… Owned by: nobody
Component: Core (Other) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Around line 150 of /django/core/validators.py is a line in which I think there's a missing backslash:

r'|^"([\001-\010\013\014\016-\037!#-\[\]-\177]|\\[\001-011\013\014\016-\177])*"' # quoted-string
                                missing backslash? ----^

If you look at the debug output of that part of the regex, I think the backslash is what is meant.

>>> re.compile(r'[\001-\011]', re.DEBUG)
in
  range (1, 9)
<_sre.SRE_Pattern object at 0x137e9b0>
>>> re.compile(r'[\001-011]', re.DEBUG)
in
  range (1, 48)
  literal 49
  literal 49
<_sre.SRE_Pattern object at 0x137ea48>

Given this, the following email should fail: "\12"@example.com

A test case:
assert(email_re.match('"\\\12"@example.com') == None)

Attachments (1)

17100.diff (1.5 KB) - added by Claude Paroz 5 years ago.
Fix missing backslash and tests

Download all attachments as: .zip

Change History (7)

comment:1 Changed 5 years ago by Claude Paroz

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

Changed 5 years ago by Claude Paroz

Attachment: 17100.diff added

Fix missing backslash and tests

comment:2 Changed 5 years ago by Claude Paroz

Has patch: set

comment:3 Changed 5 years ago by Claude Paroz

I think the fix should also be backported to stable branch.

comment:4 Changed 5 years ago by Claude Paroz

Type: UncategorizedBug
Version: 1.3SVN

comment:5 Changed 5 years ago by Aymeric Augustin

Resolution: fixed
Status: newclosed

In [17349]:

Fixed #17100 -- Typo in the regex for EmailValidator. Thanks reames AT asymmetricventures com for the report and Claude Paroz for the patch.

comment:6 Changed 5 years ago by Aymeric Augustin

In [17350]:

(The changeset message doesn't reference this ticket)

Note: See TracTickets for help on using tickets.
Back to Top