#17094 closed Bug (fixed)
DeletionMixin get_success_url parameter
Reported by: | Alejandro Varas | Owned by: | nobody |
---|---|---|---|
Component: | Documentation | Version: | 1.3 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Design decision needed | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
In https://docs.djangoproject.com/en/1.3/ref/class-based-views/#django.views.generic.edit.DeletionMixin.get_success_url says that get_success_url get a parameter(obj) but this doesn't happen on the source code.
Change History (5)
comment:1 by , 13 years ago
Triage Stage: | Unreviewed → Ready for checkin |
---|---|
Type: | Uncategorized → Bug |
comment:2 by , 13 years ago
Triage Stage: | Ready for checkin → Design decision needed |
---|
Sorry, I've been a bit too quick in my initial judgment. A case could be made that it's the code that needs changing. Indeed, the delete()
method could technically pass the deleted object to the get_success_url()
method as is currently documented. Marking as DDN as I'm personally not feeling strong about either way.
comment:4 by , 12 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Thanks, good catch.
obj
just needs to be removed from the doc (https://docs.djangoproject.com/en/dev/ref/class-based-views/#django.views.generic.edit.DeletionMixin.get_success_url).