Refactor django.template to quarantine global state

[Carl Meyer]

The template engine keeps a lot of global state around: the instantiated template loaders, the list of builtins, the cached list of loaded templatetag modules. This makes it inflexible for use as a library (you can't render different templates using different template loaders or directories or tag modules in the same process) and makes test isolation very difficult (for the same reasons).

This can be fixed via a refactoring to introduce a TemplateEngine class to encapsulate all this state. We would still create a default module-level instance of TemplateEngine based on the settings, and backwards-compatibility wrappers for the current public API that delegate to the default engine. But this would then allow alternative instances of TemplateEngine to be created and used for library use and testing, that would be self-contained and independent from settings.

In the long run, this type of refactoring is also necessary if we want to move towards "app-object" style configuration in place of global settings.

[Stephen Kelly]

For an equivalent API (in C++) see ​http://www.grantlee.org/apidox/classGrantlee_1_1Engine.html.

It also allows the case of pre-loading template tag modules brought up recently on the devel mailing list.

[anonymous]

See progress of my work at github ​https://github.com/chrismedrela/django/tree/ticket_17093.

[chrismedrela]

That was me.

[chrismedrela]

I've started discussion at django-developers mailing list ​https://groups.google.com/d/topic/django-developers/WT1cOvpPbSM/discussion.

[chrismedrela]

I rebased my work. I kept old branch and created new one (​https://github.com/chrismedrela/django/tree/ticket_17093v2) where I'm pushing my work. The branch is almost ready to review.

[chrismedrela]

Please watch new branch (​https://github.com/chrismedrela/django/tree/ticket_17093v3).

[anatoly techtonik]

What is exactly the scope of data that should encapsulated in TemplateEngine, and what will be left behind?

[Aymeric Augustin]

I'm picking this up as part of my Multiple Template Engines project.

See ​https://github.com/aaugustin/django/compare/refactor-template-engine-as-library

I'm going to perform a more intensive cleanup and reorganisation of django.template.

[Aymeric Augustin]

PR: ​https://github.com/django/django/pull/3605

[Tim Graham]

I assume this can be closed since the PR was committed. Please reopen if there is still more work to do.