Opened 13 years ago
Closed 13 years ago
#17090 closed Bug (fixed)
Problems with ModelAdmin.get_list_display()
Reported by: | Julien Phalip | Owned by: | nobody |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
While working on #16257 I've noticed some problems with the ModelAdmin.get_list_display()
method that was introduced in r16340:
- There is an inconsistency with
list_display
. If you setlist_display
to('bacon', 'cheese',)
thenget_list_display()
will return('action_checkbox', 'bacon', 'cheese',)
. - The presence (or absence) of the action checkbox should be dictated solely by the presence (or absence) of
ModelAdmin.actions
, not by what is returned byget_list_display()
.
The attached patch rectifies this behavior by injecting 'action_checkbox' further downstream after 'get_list_display()' is called. This would be a minor backwards-incompatibility for those who have been using the still-unreleased 'get_list_display()' method.
Attachments (1)
Change History (3)
by , 13 years ago
Attachment: | 17090.get_list_display-action_checkbox.diff added |
---|
comment:1 by , 13 years ago
Triage Stage: | Unreviewed → Ready for checkin |
---|---|
Version: | 1.3 → SVN |
comment:2 by , 13 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
In [17035]: