Opened 4 years ago

Closed 4 years ago

#17090 closed Bug (fixed)

Problems with ModelAdmin.get_list_display()

Reported by: julien Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

While working on #16257 I've noticed some problems with the ModelAdmin.get_list_display() method that was introduced in r16340:

  • There is an inconsistency with list_display. If you set list_display to ('bacon', 'cheese',) then get_list_display() will return ('action_checkbox', 'bacon', 'cheese',).
  • The presence (or absence) of the action checkbox should be dictated solely by the presence (or absence) of ModelAdmin.actions, not by what is returned by get_list_display().

The attached patch rectifies this behavior by injecting 'action_checkbox' further downstream after 'get_list_display()' is called. This would be a minor backwards-incompatibility for those who have been using the still-unreleased 'get_list_display()' method.

Attachments (1)

17090.get_list_display-action_checkbox.diff (4.8 KB) - added by julien 4 years ago.

Download all attachments as: .zip

Change History (3)

Changed 4 years ago by julien

comment:1 Changed 4 years ago by ramiro

  • Triage Stage changed from Unreviewed to Ready for checkin
  • Version changed from 1.3 to SVN

comment:2 Changed 4 years ago by julien

  • Resolution set to fixed
  • Status changed from new to closed

In [17035]:

Fixed #17090 -- Made the API specification for ModelAdmin.get_list_display() more consistent with that of ModelAdmin.list_display by separating out the admin action check boxes business. This is backwards-incompatible for those who have been using the still-unreleased get_list_display() method. Thanks to Ramiro Morales for the review.

Note: See TracTickets for help on using tickets.
Back to Top