Code

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#17019 closed Uncategorized (fixed)

Admin RTL CSS doesn't reset left margin on .field-box

Reported by: rem Owned by: nobody
Component: Internationalization Version: 1.3
Severity: Normal Keywords: RTL, CSS, admin
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description

.field-box has margin-right set by forms.css, and rtl.css sets an equal margin-left. This makes rows with multiple fields indented than rows with one field.

Patch attached to reset margin-right: 0; in rtl.css

Attachments (1)

django_admin_rtl_margin.diff (383 bytes) - added by rem 3 years ago.
Add margin-right: 0; to rtl.css

Download all attachments as: .zip

Change History (3)

Changed 3 years ago by rem

Add margin-right: 0; to rtl.css

comment:1 Changed 3 years ago by julien

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 3 years ago by julien

  • Resolution set to fixed
  • Status changed from new to closed

In [16947]:

Fixed #17019 -- Fixed a minor margin issue in multi-field admin form rows for right-to-left languages. Thanks to rem for the report and patch.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.