Opened 4 years ago

Closed 3 years ago

#17017 closed Cleanup/optimization (fixed)

Localization for en_GB is incorrect

Reported by: mcginness.s@… Owned by: nobody
Component: Internationalization Version: master
Severity: Normal Keywords: localization, british, dates
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description

Dates are always written with the day first in British English, so:

  • DATE_FORMAT should be similar to "25 Oct 2006" (Note the lack of a ',')
  • DATETIME_FORMAT should be similar to "25 Oct 2006, 2:30 pm"
  • MONTHDAY_FORMAT should be "25 October"

See http://en.wikipedia.org/wiki/Calendar_date#Expressing_dates_in_spoken_English for a reference

Attachments (3)

17017-r16941-abbreviated-month.diff (1016 bytes) - added by sebastian 4 years ago.
17017-r16941-long-month.diff (1.0 KB) - added by sebastian 4 years ago.
17017-r17372-abbreviated-month.diff (1018 bytes) - added by sebastian 4 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 4 years ago by sebastian

  • Easy pickings set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

I agree with the report, this seems like a legitimate change to make to the current localization. However, most sources I found only specify the long format, i.e. "25 October 2006" instead of "Oct". I am attaching two patches, one for the short format proposed in this ticket, the other for the long format (found for example in the given Wikipedia reference).

The long format with the full month is somewhat unwieldy but is used in other locales too, e.g. "de" (German).

Changed 4 years ago by sebastian

Changed 4 years ago by sebastian

comment:2 Changed 4 years ago by sebastian

  • Has patch set

Which of the two formats should be picked? "25 Oct 2006" (abbreviated) or "25 October 2006" (long)?

comment:3 Changed 4 years ago by sebastian

For reference, Python Babel with "en-gb" locale gives us "25 Oct 2006" for the standard date formatting (no format argument, i.e. implicit "medium") and uses "25 October 2006" in long format (format argument of "long").

comment:4 Changed 4 years ago by anonymous

The abbreviated form does seem more natural and is clear without being too verbose. Also, many major news and television companies in the UK use the medium form (e.g. telegraph.co.uk, guardian.co.uk, itv.com)

Changed 4 years ago by sebastian

comment:5 Changed 4 years ago by sebastian

  • Keywords localization british dates added
  • Type changed from Uncategorized to Cleanup/optimization
  • UI/UX set
  • Version changed from 1.3 to SVN

Here is an updated patch. Nothing changed really, this is just to show that the issue has not been resolved in trunk as of r17372. If somebody could review this albeit simple patch, so that it could make its way into Django 1.4, everything would be great. Thanks!

comment:6 Changed 3 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

In [17444]:

Fixed #17017 -- Updated British English date formats to follow common standards. Thanks, sebastian.

Note: See TracTickets for help on using tickets.
Back to Top