Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#17006 closed Cleanup/optimization (fixed)

Document ModelAdmin's get_form() and get_formsets()

Reported by: rasca Owned by: nobody
Component: Documentation Version: master
Severity: Normal Keywords: admin
Cc: timograham@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

They are really useful but right now their api isn't exposed or documented.

Attachments (2)

modeladmin_get_form.patch (709 bytes) - added by nkuttler 3 years ago.
17006.diff (3.0 KB) - added by timo 3 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by julien

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted
  • Type changed from Bug to Cleanup/optimization

Good idea! See also #16841.

comment:2 Changed 3 years ago by rasca

See also #17646

comment:3 Changed 3 years ago by nkuttler

SmileyChris pointed me to this bug in the IRC channel, we were talking about the ModelAdmin. A quick read through the source didn't find any get_form() for ModelForm either, so here's a trivial patch against the ModelAdmin docs to include get_form().

I would have added get_formsets() but it's undocumented in the source and I'm not really familiar with formsets.

Changed 3 years ago by nkuttler

comment:4 Changed 3 years ago by charettes

  • Keywords admin added
  • Summary changed from Document ModelForm's get_form() and get_formsets() to Document ModelAdmin's get_form() and get_formsets()

Changed 3 years ago by timo

comment:5 Changed 3 years ago by timo

  • Cc timograham@… added
  • Has patch set

comment:6 Changed 3 years ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from new to closed

In eed4faf16f37a8b0af06a52eada05b84dead4c0d:

Fixed #17006 - Documented ModelAdmin get_form() and get_formsets()

comment:7 Changed 3 years ago by Tim Graham <timograham@…>

In e7685b87c13e87d429dd30065373d8dd2f20a2e4:

[1.4.X] Fixed #17006 - Documented ModelAdmin get_form() and get_formsets()

Backport of eed4faf16f from master

comment:8 Changed 3 years ago by Tim Graham <timograham@…>

In 13bbe9161d38d3c0778577a3547fab2d181a8e5e:

[1.4.x] Fixed arguments for get_inline_instances; refs #17006.

Note: See TracTickets for help on using tickets.
Back to Top