Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#16988 closed Cleanup/optimization (fixed)

update/cleanup deprecation timeline

Reported by: Preston Holmes Owned by: Preston Holmes
Component: Documentation Version: master
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

Update deprecation timeline for 1.4 release, attempt to make language clearer and more consistent per this discussion:

http://groups.google.com/group/django-developers/t/76cd67a971f3c98a

Change History (6)

comment:1 Changed 5 years ago by Preston Holmes

Has patch: set
Owner: changed from nobody to Preston Holmes
Status: newassigned

Pull request submitted, feedback welcome

https://github.com/django/django/pull/58

comment:2 Changed 5 years ago by Julien Phalip

Patch needs improvement: set
Triage Stage: UnreviewedAccepted

Looks really good to me! I'm just made a couple of very minor comments inline at: https://github.com/django/django/pull/58/files

As a general comment, I think it might be worth adding a small paragraph at the beginning of that page explaining how the deprecation process works in Django (e.g. what the word "deprecation" means in this context; quiet vs. loud deprecation warnings, etc.). What do you think?

comment:3 Changed 5 years ago by Carl Meyer

Looks great, thanks for your work on this! I also reviewed and made some inline comments on the pull request.

Julien, I think that more general information about the deprecation process is already present in the release-process documentation, and that's linked from the top of the deprecation timeline. Seems adequate that way to me?

comment:4 Changed 5 years ago by Preston Holmes

Patch needs improvement: unset

updated pull request with inline comments, thanks guys.

RE deprecation process, I think only thing missing is a short mention that the process will be accelerated in rare cases, or for security reasons, but such clarification is not critical.

ready for additional review or checkin

comment:5 Changed 5 years ago by Carl Meyer

Patch needs improvement: set

Added three or four more minor notes, but this is almost ready IMO.

comment:6 Changed 5 years ago by Carl Meyer

Resolution: fixed
Status: assignedclosed

In [16932]:

Fixed #16988 - Clean up the deprecation timeline for language consistency. Thanks ptone.

Note: See TracTickets for help on using tickets.
Back to Top