Code

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#16988 closed Cleanup/optimization (fixed)

update/cleanup deprecation timeline

Reported by: ptone Owned by: ptone
Component: Documentation Version: master
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

Update deprecation timeline for 1.4 release, attempt to make language clearer and more consistent per this discussion:

http://groups.google.com/group/django-developers/t/76cd67a971f3c98a

Attachments (0)

Change History (6)

comment:1 Changed 3 years ago by ptone

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to ptone
  • Patch needs improvement unset
  • Status changed from new to assigned

Pull request submitted, feedback welcome

https://github.com/django/django/pull/58

comment:2 Changed 3 years ago by julien

  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

Looks really good to me! I'm just made a couple of very minor comments inline at: https://github.com/django/django/pull/58/files

As a general comment, I think it might be worth adding a small paragraph at the beginning of that page explaining how the deprecation process works in Django (e.g. what the word "deprecation" means in this context; quiet vs. loud deprecation warnings, etc.). What do you think?

comment:3 Changed 3 years ago by carljm

Looks great, thanks for your work on this! I also reviewed and made some inline comments on the pull request.

Julien, I think that more general information about the deprecation process is already present in the release-process documentation, and that's linked from the top of the deprecation timeline. Seems adequate that way to me?

comment:4 Changed 3 years ago by ptone

  • Patch needs improvement unset

updated pull request with inline comments, thanks guys.

RE deprecation process, I think only thing missing is a short mention that the process will be accelerated in rare cases, or for security reasons, but such clarification is not critical.

ready for additional review or checkin

comment:5 Changed 3 years ago by carljm

  • Patch needs improvement set

Added three or four more minor notes, but this is almost ready IMO.

comment:6 Changed 3 years ago by carljm

  • Resolution set to fixed
  • Status changed from assigned to closed

In [16932]:

Fixed #16988 - Clean up the deprecation timeline for language consistency. Thanks ptone.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.