Opened 13 years ago

Closed 13 years ago

#16923 closed Cleanup/optimization (fixed)

Remove dead code: Serializer.get_string_value

Reported by: Aymeric Augustin Owned by: nobody
Component: Core (Serialization) Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

This method isn't used anywhere is the codebase since r10554. It was only used by the XML serializer, and it was never documented.

% hg grep get_string_value
django/core/serializers/base.py:16338:    def get_string_value(self, obj, field):
django/core/serializers/xml_serializer.py:8153:            value = self.get_string_value(obj, field)

The entire test suite still passes after removing it.

Attachments (1)

16923.patch​ (586 bytes ) - added by Aymeric Augustin 13 years ago.

Download all attachments as: .zip

Change History (3)

by Aymeric Augustin, 13 years ago

Attachment: 16923.patch​ added

comment:1 by Luke Plant, 13 years ago

Triage Stage: Unreviewed → Ready for checkin

comment:2 by Aymeric Augustin, 13 years ago

Resolution: → fixed
Status: new → closed

In [16979]:

Fixed #16923 -- Removed unused method in the serialization code.

Note: See TracTickets for help on using tickets.
Back to Top