Opened 3 years ago

Closed 3 years ago

#16918 closed Bug (fixed)

BaseDateDetailView's get_object ignores queryset argument

Reported by: mitar Owned by: nobody
Component: Generic views Version: 1.3
Severity: Normal Keywords:
Cc: mmitar@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no


BaseDateDetailView's get_object ignore queryset argument, while in documentation it is written that:

If queryset is provided, that queryset will be used as the source of objects; otherwise, get_queryset() will be used.

Attachments (1)

16918.diff (2.8 KB) - added by koenb 3 years ago.
patch with test for #16918

Download all attachments as: .zip

Change History (7)

comment:1 Changed 3 years ago by mitar

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Summary changed from BaseDateDetailView's get_object ignore queryset argument to BaseDateDetailView's get_object ignores queryset argument

comment:2 Changed 3 years ago by mattmcc

  • Triage Stage changed from Unreviewed to Accepted

Changed 3 years ago by koenb

patch with test for #16918

comment:3 Changed 3 years ago by koenb

  • Has patch set

Added a patch with test

comment:4 Changed 3 years ago by anonymous

  • Triage Stage changed from Accepted to Ready for checkin

comment:5 Changed 3 years ago by ptone

bah - FWIW - I was the one who RFC - patch applied cleanly, and all tests pass, patch fixes impl to match docs - and has good coverage with tests.

comment:6 Changed 3 years ago by julien

  • Resolution set to fixed
  • Status changed from new to closed

In [16974]:

Fixed #16918 -- Ensured that custom querysets are used when provided to BaseDateDetailView.get_object(). Thanks to mitar for the report, to koenb for the patch and to Preston Holmes for the review.

Add Comment

Modify Ticket

Change Properties
<Author field>
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.