Opened 5 years ago

Closed 5 years ago

#16918 closed Bug (fixed)

BaseDateDetailView's get_object ignores queryset argument

Reported by: Mitar Owned by: nobody
Component: Generic views Version: 1.3
Severity: Normal Keywords:
Cc: mmitar@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

BaseDateDetailView's get_object ignore queryset argument, while in documentation it is written that:

If queryset is provided, that queryset will be used as the source of objects; otherwise, get_queryset() will be used.

Attachments (1)

16918.diff (2.8 KB) - added by Koen Biermans 5 years ago.
patch with test for #16918

Download all attachments as: .zip

Change History (7)

comment:1 Changed 5 years ago by Mitar

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Summary: BaseDateDetailView's get_object ignore queryset argumentBaseDateDetailView's get_object ignores queryset argument

comment:2 Changed 5 years ago by Matt McClanahan

Triage Stage: UnreviewedAccepted

Changed 5 years ago by Koen Biermans

Attachment: 16918.diff added

patch with test for #16918

comment:3 Changed 5 years ago by Koen Biermans

Has patch: set

Added a patch with test

comment:4 Changed 5 years ago by anonymous

Triage Stage: AcceptedReady for checkin

comment:5 Changed 5 years ago by Preston Holmes

bah - FWIW - I was the one who RFC - patch applied cleanly, and all tests pass, patch fixes impl to match docs - and has good coverage with tests.

comment:6 Changed 5 years ago by Julien Phalip

Resolution: fixed
Status: newclosed

In [16974]:

Fixed #16918 -- Ensured that custom querysets are used when provided to BaseDateDetailView.get_object(). Thanks to mitar for the report, to koenb for the patch and to Preston Holmes for the review.

Note: See TracTickets for help on using tickets.
Back to Top