Opened 19 years ago
Closed 18 years ago
#1690 closed defect (duplicate)
Validators which check other fields don't work with edit_inline
Reported by: | Esaj | Owned by: | Adrian Holovaty |
---|---|---|---|
Component: | Validators | Version: | |
Severity: | normal | Keywords: | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Validators which check other fields don't work with edit_inline.
Take django.core.validators.RequiredIfOtherFieldEquals
for example:
This validates by checking if all_data[self.other_field]
equals self.other_value
. However, with edit_inline, all_data
contains keys of the form foo.0.field_name
, hence using self.other_field
as a key for all_data
doesn't work.
Ideally, for edit_inline, the validator should be passed a modified all_data
dict with only the relevant fields in it. Maybe DotExpandedDict
would come in handy when implementing this?
Change History (2)
comment:1 by , 19 years ago
comment:2 by , 18 years ago
Resolution: | → duplicate |
---|---|
Status: | new → closed |
I'm marking this a dup of #265 as it appears to be the same issue and has some code attached.
There are a couple of sides to this behaviour, it seems. I am trying to start a discussion on the developers list to work out what we really want to do here: http://groups.google.com/group/django-developers/browse_frm/thread/123a0a9ba53753b2/e31cb47a017b69cd#e31cb47a017b69cd