Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#16897 closed Bug (fixed)

makemessages option_list default value for "extensions" is missing .txt

Reported by: Simon Meers Owned by: nobody
Component: Core (Management commands) Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

Looks like r16437 updated everything except the option_list. Simple patch attached. Of course we might also consider listing the conditional '.js' switch here as well, but maybe that's too much detail for the option_list.

Attachments (2)

16897.diff​ (1010 bytes ) - added by Simon Meers 13 years ago.
16897_v2.diff​ (1.0 KB ) - added by Simon Meers 13 years ago.

Download all attachments as: .zip

Change History (6)

by Simon Meers, 13 years ago

Attachment: 16897.diff​ added

comment:1 by Julien Phalip, 13 years ago

Has patch: set
Needs tests: set
Triage Stage: Unreviewed → Accepted

I got bitten by this too. This wouldn't have been missed if there were tests, so it'd be good to add some :-)

comment:2 by Simon Meers, 13 years ago

Seriously, tests for help strings?

comment:3 by Julien Phalip, 13 years ago

Needs tests: unset
Patch needs improvement: set

Woops, sorry I got confused there! :P

While we're fixing this I think it's worth adding a note that the default is '.js' if the domain is 'djangojs'.

by Simon Meers, 13 years ago

Attachment: 16897_v2.diff​ added

comment:4 by Julien Phalip, 13 years ago

Resolution: → fixed
Status: new → closed

In [16864]:

Fixed #16897 -- Fixed some docstrings and help texts for the makemessages management command. Thanks, Simon Meers.

Note: See TracTickets for help on using tickets.
Back to Top