Importing models.py from not-installed app prevents any other app with that label from loading
|Reported by:||carljm||Owned by:||nott|
|Component:||Database layer (models, ORM)||Version:||master|
|Has patch:||no||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
If a models.py from an app that is not listed in INSTALLED_APPS happens to be imported for whatever reason, that (not-installed) app takes over the app-label in the app cache, making it impossible for any app actually in INSTALLED_APPS to use that app-label. This is wrong - an import should not have such a side effect. INSTALLED_APPS should be the arbiter of what apps are actually found in the app cache.
The fix for #16283 worked around this problem and removed the immediate symptom, but didn't address the underlying issue.
The fix for #15866 addressed a similar issue, but didn't fix this.
This may be fixed in the app-loading branch, and in any case is closely-related to the changes there.
Attached tarball is a simplest-case settings.py and app demonstrating the issue; run "manage.py validate" to see the problem. The models from contrib.auth are being validated even though that app is not installed, simply because its models.py has been imported. The presence of another INSTALLED_APP with the "auth" app-label causes the app cache to be confused into thinking that contrib.auth is actually installed, when it is not.
Change History (4)
Changed 5 years ago by carljm
comment:2 Changed 2 years ago by nott
- Owner changed from nobody to nott
- Status changed from new to assigned