Opened 4 years ago

Closed 2 months ago

#16867 closed New feature (fixed)

Validate GenericForeignKey's object_id_field/content_type_field options

Reported by: jacob Owned by: nobody
Component: contrib.contenttypes Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by ramiro)

See #7800

The object_id_field and content_type_field options to GenericForeignKey aren't validated by model validation, which means that if you make a mistake or typo weird stuff happens. ./ validate should complain about that.

I think this is probably blocking on the ability to plug into model validation since GFK's are in contrib and shouldn't have code in core.

Change History (3)

comment:1 Changed 4 years ago by kmtracey

Yes, see #16283 for why validation of contrib.contenttypes stuff is problematic at the moment.

comment:2 Changed 3 years ago by ramiro

  • Description modified (diff)

comment:3 Changed 2 months ago by timgraham

  • Resolution set to fixed
  • Status changed from new to closed
  • Type changed from Bug to New feature

Validation for these fields was added in Django 1.7 in the initial version of the checks framework, d818e0c9b2b88276cc499974f9eee893170bf0a8.

Note: See TracTickets for help on using tickets.
Back to Top