Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#16852 closed Bug (fixed)

"Save and continue editing" and "Save and add another" swapped in 1.3.1

Reported by: Jochem Owned by: Julien Phalip
Component: contrib.admin Version: 1.3
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

It seems that the IE7 specific fix from changeset 16683 (https://code.djangoproject.com/changeset/16683) causes the "Save and continue editing" and "Save and add another" to be swapped from place in all browsers. Shouldn't IE specific fixes be in ie.css instead of forms.css?

Change History (4)

comment:1 Changed 5 years ago by Julien Phalip

Owner: changed from nobody to Julien Phalip
Severity: NormalRelease blocker
Triage Stage: UnreviewedAccepted

Thanks for the report. My bad was having backported it to r16684, too. This is minor, but it needs to be rectified.

comment:2 Changed 5 years ago by Julien Phalip

In [16834]:

[1.3.X] Reverted the change in r16684, which, while fixing an alignment issue in IE7 with the admin's "Save and continue editing" and "Save and add another" buttons, caused the swapping of those buttons' order. Thanks to jocmeh for the report. Refs #16852.

comment:3 Changed 5 years ago by Julien Phalip

In [16835]:

Reverted the change in r16683, which, while fixing an alignment issue in IE7 with the admin's "Save and continue editing" and "Save and add another" buttons, caused the swapping of those buttons' order. Thanks to jocmeh for the report. Refs #16852.

comment:4 Changed 5 years ago by Julien Phalip

Resolution: fixed
Status: newclosed

OK, there is no non-hacky way to get around IE7's issues with text-align. This was not a critical problem, therefore I've simply reverted the "fixes" both in trunk and in 1.3.X.

Note: See TracTickets for help on using tickets.
Back to Top