Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16848 closed Bug (fixed)

r16830 creates a lot of failures in the test suite

Reported by: Aymeric Augustin Owned by: nobody
Component: HTTP handling Version: 1.3
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Change History (2)

comment:1 Changed 7 years ago by Preston Holmes

Triage Stage: UnreviewedAccepted

Yup - just ran into this while trying to review patches - badly badly broken :)

comment:2 Changed 7 years ago by Carl Meyer

Resolution: fixed
Status: newclosed

In [16831]:

Fixed #16848 - Adjusted SimpleTemplateResponse.init to be less brittle.

Could have reverted r16830 instead, but HttpResponse shouldn't have to dance
around and do non-obvious things to keep TemplateResponse happy,
TemplateResponse should be robust against the possibility that
HttpResponse.init might set self.content.

Note: See TracTickets for help on using tickets.
Back to Top