Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#16835 closed New feature (fixed)

filter users by group

Reported by: Wim Feijen <wim@…> Owned by: Dan Loewenherz
Component: contrib.auth Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

When using groups, it is very handy to be able to filter users by group, in the user list in het admin.

Attachments (1)

filter_users_by_group.diff (671 bytes) - added by Wim Feijen <wim@…> 5 years ago.

Download all attachments as: .zip

Change History (15)

Changed 5 years ago by Wim Feijen <wim@…>

Attachment: filter_users_by_group.diff added

comment:1 Changed 5 years ago by Aymeric Augustin

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

This might be difficult to use on sites where there is a huge number of groups, but:

  • the groups appear below the other filters, which preserves usability;
  • for the vast majority of the sites, it should be useful.

Accepting the ticket for this reason.

comment:2 Changed 5 years ago by Preston Holmes

Has patch: set
milestone: 1.4

comment:3 Changed 5 years ago by Jacob

milestone: 1.4

Milestone 1.4 deleted

comment:4 Changed 4 years ago by Dmitry Sosedov

Owner: changed from nobody to Dmitry Sosedov

comment:5 Changed 4 years ago by Dmitry Sosedov

Resolution: fixed
Status: newclosed

comment:6 Changed 4 years ago by Claude Paroz

Resolution: fixed
Status: closedreopened

Please do not close tickets without explanations.

comment:7 Changed 4 years ago by Claude Paroz

Owner: Dmitry Sosedov deleted
Status: reopenednew

comment:8 Changed 4 years ago by Dmitry Sosedov

I probably shouldn't close the ticket to begin with since I cannot commit anything. I just tried to understand the process. Got it now. Thanks!

Last edited 4 years ago by Dmitry Sosedov (previous) (diff)

comment:9 Changed 4 years ago by Dan Loewenherz

Component: contrib.authcontrib.admin
Triage Stage: AcceptedReady for checkin

Patch successfully applies to master, works as expected.

comment:10 Changed 4 years ago by Dan Loewenherz

Owner: set to Dan Loewenherz
Status: newassigned

comment:12 Changed 4 years ago by Preston Holmes

Component: contrib.admincontrib.auth

Thanks for the patch - landing it in a second - just FYI in general avoid RFCing your own patches, for small patches like this where docs/tests essentially don't apply - it can be OK, but even then it is preferred to wait a bit after attaching the patch to see if someone might RFC it first.

https://docs.djangoproject.com/en/dev/internals/contributing/triaging-tickets/#ready-for-checkin

comment:13 Changed 4 years ago by Preston Holmes <preston@…>

Resolution: fixed
Status: assignedclosed

In 69ff1b7390e140f332a5aa55c44a091c838923fb:

Fixed #16835 -- add groups to auth.user admin list_filter

comment:14 Changed 4 years ago by Dan Loewenherz

Thanks!

PS Someone else wrote the patch, I just marked RFC and became the owner since the person who originally wrote the issue appeared to have disappeared.

Note: See TracTickets for help on using tickets.
Back to Top