Code

Opened 3 years ago

Closed 19 months ago

Last modified 19 months ago

#16835 closed New feature (fixed)

filter users by group

Reported by: Wim Feijen <wim@…> Owned by: dloewenherz
Component: contrib.auth Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

When using groups, it is very handy to be able to filter users by group, in the user list in het admin.

Attachments (1)

filter_users_by_group.diff (671 bytes) - added by Wim Feijen <wim@…> 3 years ago.

Download all attachments as: .zip

Change History (15)

Changed 3 years ago by Wim Feijen <wim@…>

comment:1 Changed 3 years ago by aaugustin

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

This might be difficult to use on sites where there is a huge number of groups, but:

  • the groups appear below the other filters, which preserves usability;
  • for the vast majority of the sites, it should be useful.

Accepting the ticket for this reason.

comment:2 Changed 3 years ago by ptone

  • Has patch set
  • milestone set to 1.4

comment:3 Changed 3 years ago by jacob

  • milestone 1.4 deleted

Milestone 1.4 deleted

comment:4 Changed 2 years ago by mitya

  • Owner changed from nobody to mitya

comment:5 Changed 2 years ago by mitya

  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed 2 years ago by claudep

  • Resolution fixed deleted
  • Status changed from closed to reopened

Please do not close tickets without explanations.

comment:7 Changed 2 years ago by claudep

  • Owner mitya deleted
  • Status changed from reopened to new

comment:8 Changed 2 years ago by mitya

I probably shouldn't close the ticket to begin with since I cannot commit anything. I just tried to understand the process. Got it now. Thanks!

Last edited 2 years ago by mitya (previous) (diff)

comment:9 Changed 20 months ago by dloewenherz

  • Component changed from contrib.auth to contrib.admin
  • Triage Stage changed from Accepted to Ready for checkin

Patch successfully applies to master, works as expected.

comment:10 Changed 20 months ago by dloewenherz

  • Owner set to dloewenherz
  • Status changed from new to assigned

comment:12 Changed 19 months ago by ptone

  • Component changed from contrib.admin to contrib.auth

Thanks for the patch - landing it in a second - just FYI in general avoid RFCing your own patches, for small patches like this where docs/tests essentially don't apply - it can be OK, but even then it is preferred to wait a bit after attaching the patch to see if someone might RFC it first.

https://docs.djangoproject.com/en/dev/internals/contributing/triaging-tickets/#ready-for-checkin

comment:13 Changed 19 months ago by Preston Holmes <preston@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 69ff1b7390e140f332a5aa55c44a091c838923fb:

Fixed #16835 -- add groups to auth.user admin list_filter

comment:14 Changed 19 months ago by dloewenherz

Thanks!

PS Someone else wrote the patch, I just marked RFC and became the owner since the person who originally wrote the issue appeared to have disappeared.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.