Opened 13 years ago
Closed 13 years ago
#16816 closed Bug (fixed)
URLField validation mock added in r16451 neutered by changes from r16760
Reported by: | Ramiro Morales | Owned by: | nobody |
---|---|---|---|
Component: | Testing framework | Version: | dev |
Severity: | Release blocker | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
The mocking is done so the test suite doesn't depend on Internet connectivity. We need to update the strategy we use to accompany the new implementation of the validation code.
Attachments (4)
Change History (10)
comment:1 by , 13 years ago
Severity: | Normal → Release blocker |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 13 years ago
milestone: | 1.4 |
---|
by , 13 years ago
Attachment: | 16816.verify-exists-test-mock.diff added |
---|
by , 13 years ago
Attachment: | 16816.verify-exists-test-mock.2.diff added |
---|
comment:3 by , 13 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
comment:4 by , 13 years ago
Triage Stage: | Ready for checkin → Accepted |
---|
Moving back to accepted because it works on Python 2.5 but fails with 2.6 and 2.7
by , 13 years ago
Attachment: | 16816.verify-exists-test-mock.3.diff added |
---|
comment:5 by , 13 years ago
The failures in Python > 2.5 were due to the fact that urllib2.OpenerDirector.open()
has an extra timeout
parameter. I've added it to the mock open()
method and that seems to fix it.
by , 13 years ago
Attachment: | 16816.verify-exists-test-mock.4.diff added |
---|
Small tweak to the previous patch. Not sure where to move verify_exists_urls() to avoid doing that ugly relative import in validation/tests.py
Milestone 1.4 deleted