Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#16789 closed Cleanup/optimization (fixed)

use named urls in django.contrib.auth.urls

Reported by: wim@… Owned by: Flavio Curella
Component: contrib.auth Version: 1.3
Severity: Normal Keywords:
Cc: chris@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Use named urls in django.contrib.auth: eat own dogfood and make it possible to use reverse auth urls for everyone! Freedom to the people!

Attachments (3)

named_auth_urls_ticket16789.diff (2.0 KB) - added by wim@… 5 years ago.
add names to auth/urls.py
t16789-with-docs.diff (5.1 KB) - added by Chris Heisel 5 years ago.
Named URL patterns plus docs
t16789-with-docs-and-tests.diff (7.3 KB) - added by Chris Heisel 5 years ago.
Docs and tests

Download all attachments as: .zip

Change History (19)

Changed 5 years ago by wim@…

add names to auth/urls.py

comment:1 Changed 5 years ago by Flavio Curella

Component: Uncategorizedcontrib.auth
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

comment:2 Changed 5 years ago by Flavio Curella

Has patch: set
Needs documentation: set

I think we should document the view names somewhere in the docs.

comment:3 Changed 5 years ago by Chris Heisel

Owner: changed from nobody to Chris Heisel
Status: newassigned

comment:4 Changed 5 years ago by Chris Heisel

Needs documentation: unset
Owner: changed from Chris Heisel to Flavio Curella
Status: assignednew
Triage Stage: UnreviewedAccepted

Updated patch with documentation. Sending to fcurella for review.

comment:5 Changed 5 years ago by wim@…

Hi cmheisel,

It seems the diff contains more than one fix. Could you please look into this?

Thanks!

Wim

Changed 5 years ago by Chris Heisel

Attachment: t16789-with-docs.diff added

Named URL patterns plus docs

comment:6 Changed 5 years ago by Chris Heisel

Wim / fcurella -- sorry about that! Fixed the patch.

comment:7 Changed 5 years ago by Chris Heisel

Cc: chris@… added

comment:8 Changed 5 years ago by Flavio Curella

Triage Stage: AcceptedReady for checkin

comment:9 Changed 5 years ago by Flavio Curella

Needs tests: set
Triage Stage: Ready for checkinAccepted

Not sure if tests for this patch would be overkill.

Last edited 5 years ago by Flavio Curella (previous) (diff)

comment:10 Changed 5 years ago by wim@…

We could just do a reverse lookup for the url names?

Changed 5 years ago by Chris Heisel

Docs and tests

comment:11 Changed 5 years ago by Chris Heisel

Needs tests: unset

Added a new patch that includes tests as well

comment:12 Changed 5 years ago by wim@…

Hi cmheisel,

Thanks for the patch! I want to run it and the tests to mark it as Ready for Checkin, however, unfortunately, I am unable to apply your patch, because it is not a svn diff. Could you make it into a svn diff?

As far as I know, patches are supplied here as svn diffs at the ticket. Or did I miss something and did this policy change?

Wim

comment:13 Changed 5 years ago by Chris Heisel

Wim,

Sure thing, I didn't realize they weren't compatible.

I'll generate a plain-ole-diff and resubmit.

Chris

comment:14 Changed 5 years ago by Alex Gaynor

comment:15 Changed 5 years ago by Wim Feijen <wim@…>

Triage Stage: AcceptedReady for checkin

Thanks Alex.

Patch and docs are complete, so: ready for check-in.

comment:16 Changed 5 years ago by Ramiro Morales

Resolution: fixed
Status: newclosed

In [16901]:

Fixed #16789 -- Added names to URLs in convenience contrib.auth urls.py.

Thanks wim AT go2people DOT nl for the report, cmheisel for the patch and
fcurella for reviewing it.

Note: See TracTickets for help on using tickets.
Back to Top