Code

Opened 3 years ago

Closed 3 years ago

#16729 closed Bug (fixed)

inconsistency between doc and code for oracle DB backend

Reported by: simon.cruanes.2007@… Owned by: nobody
Component: Database layer (models, ORM) Version: 1.3
Severity: Normal Keywords: oracle doc option
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

According to the doc for the oracle DB backend, at
https://docs.djangoproject.com/en/dev/ref/settings/?from=olddocs#test-create-user
the option to prevent a user from being created during tests is
TEST_CREATE_USER.

However, this option has no effect since the code at
https://code.djangoproject.com/browser/django/trunk/django/db/backends/oracle/creation.py#L219
uses 'TEST_USER_CREATE' instead of 'TEST_CREATE_USER'.

This is an inconsistency between code and doc, imho it should be enough to update the doc.

Attachments (1)

16729.patch (499 bytes) - added by aaugustin 3 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 3 years ago by simon.cruanes.2007@…

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Summary changed from inconsitency between doc and code for oracle DB backend to inconsistency between doc and code for oracle DB backend

comment:2 Changed 3 years ago by aaugustin

  • Has patch set
  • Triage Stage changed from Unreviewed to Accepted

Changed 3 years ago by aaugustin

comment:3 Changed 3 years ago by aaugustin

This was a typo in my patch for #16478 that was committed last week in r16646.

comment:4 Changed 3 years ago by julien

  • Triage Stage changed from Accepted to Ready for checkin

comment:5 Changed 3 years ago by julien

  • Resolution set to fixed
  • Status changed from new to closed

In [16716]:

Fixed #16729 -- Fixed a small typo in the settings reference doc. Thanks to simon.cruanes.2007@… for the report and to Aymeric Augustin for the patch.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.