Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#16650 closed Bug (wontfix)

BaseCommentNode in comments template tags shouldn't filter "is_public" comments

Reported by: Guilherme Gondim Owned by: nobody
Component: contrib.comments Version: 1.3
Severity: Normal Keywords: templatetag
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The template tag get_comment_list should query all comments instead only the is_public ones.

Why? The developer might want show a message "Comment waiting for moderation." instead just hide it completely. A developer can simple don't show those comments with a if in the template if he want hide non-public comments.

I know that is not a big problem and also that is a backward-incompatible change, but IMHO that is not a good behavior.

Change History (2)

comment:1 Changed 5 years ago by Aymeric Augustin

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Resolution: wontfix
Status: newclosed

Well, this is quite debatable. Not including unmoderated comments by default ensures that they can't be shown accidentally.

If we changed this behavior, every developer would have to add a special case to its templates to hide unmoderated comments, or display them differently, which is backwards incompatible.

comment:2 Changed 5 years ago by Guilherme Gondim

Yeah, that is also my concern. I will think in a elegant solution or just create a template tag for my needs. Thank you!

(Maybe I should had discussed it in the developers list before.)

Note: See TracTickets for help on using tickets.
Back to Top