Opened 8 years ago

Closed 8 years ago

#16631 closed Bug (fixed)

Logic in check_settings() in staticfiles app when no base_file is given is wrong

Reported by: Andi Albrecht Owned by: nobody
Component: contrib.staticfiles Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


" runserver" fails even when STATIC_URL is configured in with the following exception:

Traceback (most recent call last):
File "/home/andi/devel/dlgi/django/core/management/commands/", line 110, in inner_run
handler = self.get_handler(*args, **options)
File "/home/andi/devel/dlgi/django/contrib/staticfiles/management/commands/", line 26, in get_handler
handler = StaticFilesHandler(handler)
File "/home/andi/devel/dlgi/django/contrib/staticfiles/", line 21, in init
self.base_url = urlparse(self.get_base_url())
File "/home/andi/devel/dlgi/django/contrib/staticfiles/", line 28, in get_base_url
File "/home/andi/devel/dlgi/django/contrib/staticfiles/", line 49, in check_settings
"You're using the staticfiles app "
django.core.exceptions.ImproperlyConfigured: You're using the staticfiles app without having set the required STATIC_URL setting.

Attachments (1)

staticfiles_logic.diff (478 bytes) - added by Andi Albrecht 8 years ago.

Download all attachments as: .zip

Change History (2)

Changed 8 years ago by Andi Albrecht

Attachment: staticfiles_logic.diff added

comment:1 Changed 8 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed

In [16618]:

Fixed #16631 -- Fixed embarrassing typo introduced in r16617. Thanks, Andi Albrecht.

Note: See TracTickets for help on using tickets.
Back to Top